Fix JWT verification to EdDSA and add sub-account message visibility#30
Merged
Conversation
The RS256 rework in #24 assumed a switch to an RSA-based IdP that never happened; idp.fmsg.io signs EdDSA (Ed25519) tokens with the address in `sub` and no `aud` claim, so HEAD would reject every real login. Restore EdDSA verification and make audience optional to match reality. Also implement the visibility model the sub-account feature was built for: an owner sees their own messages plus their derived sub-accounts', while a sub-account (via its own API-key token or the owner's X-FMSG-Act-As) still sees only itself. Write paths are unchanged. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RS256 rework in #24 assumed a switch to an RSA-based IdP that never happened; restore EdDSA verification and make audience optional.
Also implement the visibility model the sub-account feature was built for: an owner sees their own messages plus their derived sub-accounts', while a sub-account (via its own API-key token or the owner's X-FMSG-Act-As) still sees only itself. Write paths are unchanged.